Description

Resolves simulation test failures introduced in #11924.

x/staking failure

Symptom of this failure is the descriptive log message

Simulating... block 5/50, operation 500/753. Logs to writing to /home/mkoco/.simapp/simulations/2022-05-25_16:39:13.log
    simulate.go:302: error on block  5/50, operation (534/753) from x/staking:
        failed to execute message; message index: 0: amount is greater than the unbonding delegation entry balance: invalid request [/home/mkoco/go/pkg/mod/cosmossdk.io/errors@v1.0.0-beta.6/errors.go:187]
        Comment: unable to deliver tx

originating in x/staking/keeper/msg_server.CancelUnbondingDelegation. I was not able to find a concrete fix other than re-adding a new instance of the params module back to SimApp's call to module.NewSimulationManager which evidently has a side-effect I do not understand.

store test failure

error log:

compared 0 different key/value pairs between KVStoreKey{0xc0010c5e00, acc} and KVStoreKey{0xc000b44560, acc}
compared 0 different key/value pairs between KVStoreKey{0xc0010c5e20, staking} and KVStoreKey{0xc000b44580, staking}
compared 0 different key/value pairs between KVStoreKey{0xc0010c5e50, slashing} and KVStoreKey{0xc000b445b0, slashing}
compared 0 different key/value pairs between KVStoreKey{0xc0010c5e30, mint} and KVStoreKey{0xc000b44590, mint}
compared 0 different key/value pairs between KVStoreKey{0xc0010c5e40, distribution} and KVStoreKey{0xc000b445a0, distribution}
compared 0 different key/value pairs between KVStoreKey{0xc0010c5e10, bank} and KVStoreKey{0xc000b44570, bank}
--- FAIL: TestAppImportExport (17.93s)
panic: kv store with key <nil> has not been registered in stores [recovered]

originating in sim_test.go. The root cause here seems to be test code which either fetches from SimApp.keys directly or uses SimApp.GetKey to fetch a StoreKey instance in order to build a keeper for various testing functions. Use of this pattern is ubiquitous:

To this end a store key fetching function was added to runtime/app. As more keepers are moved over to the runtime they should just work in test as SimApp.GetKey now falls back to App.FindStoreKey on not found. I am not a huge fan of this approach since it's exposing runtime internals, alternative approaches include:

• maintain a duplicate list of storeKeys derived from runtime in SimApp
• refactor all testing code (37 usages) to build/fetch keepers in a different way so this dependency can be removed (not sure how possible this without reviewing each usage)
• as per @aaronc use an unsafe flag to disable FindStoreKey by deafult

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)